fix: correct player spawn in 1.20.1- by huanmeng-qwq · Pull Request #35 · Tofaa2/EntityLib

huanmeng-qwq · 2025-07-07T18:01:02Z

Summary by CodeRabbit

New Features
- Improved compatibility with different Minecraft server versions by introducing version-specific handling for player entity spawning.
- Enhanced player spawn behavior with additional rotation and head look synchronization.
Refactor
- Streamlined internal logic for entity spawning to enhance maintainability and adaptability across server versions.

coderabbitai · 2025-07-07T18:01:08Z

Walkthrough

The changes refactor spawn packet creation in the entity wrapper classes. The base entity class now uses a helper method for packet creation, with a generalized return type. The player wrapper class overrides this method to implement version-specific logic for packet creation and adds an extended spawn packet list including rotation and head look packets, ensuring compatibility with different server versions.

Changes

File(s)	Change Summary
.../wrapper/WrapperEntity.java	Refactored spawn packet creation to use a helper method; changed return type to a generic `PacketWrapper<?>`.
.../wrapper/WrapperPlayer.java	Added version-specific override for spawn packet creation; added extended spawn packets including rotation and head look; refined imports.

Sequence Diagram(s)

sequenceDiagram
    participant Server
    participant WrapperEntity
    participant WrapperPlayer
    participant PacketWrapper

    Server->>WrapperEntity: spawn(location, parent)
    WrapperEntity->>WrapperEntity: createSpawnPacket()
    alt Entity is Player and version <= 1.20.1
        WrapperEntity->>WrapperPlayer: createSpawnPacket()
        WrapperPlayer->>PacketWrapper: create WrapperPlayServerSpawnPlayer packet
    else Entity is Player and version > 1.20.1
        WrapperEntity->>PacketWrapper: createSpawnPacket() (superclass logic)
    else Other Entity
        WrapperEntity->>PacketWrapper: createSpawnPacket()
    end
    WrapperPlayer->>WrapperPlayer: createSpawnPackets()
    WrapperPlayer->>PacketWrapper: add rotation and head look packets
    WrapperEntity->>Server: Send PacketWrapper(s)

Poem

🐇 In code’s soft burrow, packets play,
Wrapped anew in a clever way.
For players old and versions bright,
Spawn packets leap into the light.
Rotation, look, all in a line,
Hopping through code, so neat, so fine!
✨📦

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8478e87 and 8bc8bfb.

📒 Files selected for processing (1)

api/src/main/java/me/tofaa/entitylib/wrapper/WrapperPlayer.java (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

api/src/main/java/me/tofaa/entitylib/wrapper/WrapperPlayer.java

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

huanmeng-qwq · 2025-07-07T18:11:11Z

By the way, the project's dependency on packetevents seems quite old. The latest version of EntityData has added generic type support.

Tofaa2 · 2025-07-07T18:38:29Z

By the way, the project's dependency on packetevents seems quite old. The latest version of EntityData has added generic type support.

Due to some unforeseen stuff with my irl work (I've explained in the Discord) I've not had a lot of time to work on EntityLib as i had months prior. Though the generic boxing doesn't really affect us

Tofaa2 · 2025-07-07T18:38:42Z

LGTM 👍🏿 Thank you for your pull request

fix: correct player spawn in 1.20.1-

8478e87

feat: Add rotation packet handling after player spawn.

8bc8bfb

Tofaa2 merged commit 49943c9 into Tofaa2:master Jul 7, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct player spawn in 1.20.1-#35

fix: correct player spawn in 1.20.1-#35
Tofaa2 merged 2 commits intoTofaa2:masterfrom
huanmeng-qwq:master

huanmeng-qwq commented Jul 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

huanmeng-qwq commented Jul 7, 2025

Uh oh!

Tofaa2 commented Jul 7, 2025

Uh oh!

Tofaa2 commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

huanmeng-qwq commented Jul 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

huanmeng-qwq commented Jul 7, 2025

Uh oh!

Tofaa2 commented Jul 7, 2025

Uh oh!

Tofaa2 commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

huanmeng-qwq commented Jul 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)